Improve support for conditional Square payments by Crabcyborg · Pull Request #2594 · Strategy11/formidable-forms

Crabcyborg · 2025-11-19T21:06:16Z

Related issue https://github.com/Strategy11/formidable-pro/issues/6100

This is mostly copied from where I added the same support for Stripe Link (https://github.com/Strategy11/formidable-stripe/pull/332).

When the Payment field is conditionally hidden, the submit button should not be disabled when Stripe Link is incomplete.
When the payment field is made visible, the submit button will be disabled if Stripe link is incomplete.

TODO

Test submit button conditional logic.
Consider minifying the JS since it's growing.

coderabbitai · 2026-04-27T18:20:45Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7c7b6104-f6f1-4d19-b79e-3b7115e9fc86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch improve_support_for_conditional_square

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

deepsource-io · 2026-04-27T18:22:25Z

DeepSource Code Review

We reviewed changes in 1d27050...f94f0ef on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Apr 27, 2026 7:03p.m.	Review ↗
JavaScript		Apr 27, 2026 7:03p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-04-27T18:23:23Z

+	 * @returns {bool}
+	 */
+	function submitButtonIsConditionallyDisabled( formId ) {
+		return submitButtonIsConditionallyNotAvailable( formId ) && 'disable' === __FRMRULES[ 'submit_' + formId ].hideDisable;


Unexpected string concatenation

In ES2015 (ES6), we can use template literals instead of string concatenation.

deepsource-io · 2026-04-27T18:23:23Z

+	 * @returns bool
+	 */
+	function submitButtonIsConditionallyNotAvailable( formId ) {
+		var hideFields = document.getElementById( 'frm_hide_fields_' + formId );


Unexpected var, use let or const instead

It is recommended to use let or const over var.
This will help prevent re-declaration of variables that are in the global scope when using var.

deepsource-io · 2026-04-27T18:23:23Z

+	 * @returns bool
+	 */
+	function submitButtonIsConditionallyNotAvailable( formId ) {
+		var hideFields = document.getElementById( 'frm_hide_fields_' + formId );


Unexpected string concatenation

In ES2015 (ES6), we can use template literals instead of string concatenation.

deepsource-io · 2026-04-27T18:23:23Z

+	 */
+	function submitButtonIsConditionallyNotAvailable( formId ) {
+		var hideFields = document.getElementById( 'frm_hide_fields_' + formId );
+		return hideFields && -1 !== hideFields.value.indexOf( '["frm_form_' + formId + '_container .frm_final_submit"]' );


Unexpected string concatenation

In ES2015 (ES6), we can use template literals instead of string concatenation.

deepsource-io · 2026-04-27T18:29:35Z

+	 */
+	function submitButtonIsConditionallyNotAvailable( formId ) {
+		const hideFields = document.getElementById( `frm_hide_fields_${ formId }` );
+		return hideFields && hideFields.value.includes( `["frm_form_${ formId }_container .frm_final_submit"]` );


Prefer using an optional chain expression instead, as it's more concise and easier to read

The optional chaining operator can be used to perform null checks before accessing a property, or calling a function.

Crabcyborg added 3 commits November 19, 2025 17:05

Improve support for conditional square

8df9923

Update since versions, remove each function (not necessary)

abd1b99

Call recalculate size after conditionally showing the payment field

ffe463f

Crabcyborg changed the title ~~Improve support for conditional square~~ Improve support for conditional Square payments Nov 19, 2025

Crabcyborg added the run analysis label Nov 19, 2025

Crabcyborg added this to the 6.27 milestone Dec 8, 2025

Crabcyborg modified the milestones: 6.27, 6.28 Jan 5, 2026

Crabcyborg modified the milestones: 6.28, 6.29 Feb 12, 2026

Crabcyborg modified the milestones: 6.29, 6.30 Mar 9, 2026

Crabcyborg modified the milestones: 6.30 (Pricing Fields), 6.31 (PayPal Commerce) Apr 15, 2026

Merge branch 'master' into improve_support_for_conditional_square

292d64a

deepsource-io Bot reviewed Apr 27, 2026

View reviewed changes

Run eslint fixer

880260d

deepsource-io Bot reviewed Apr 27, 2026

View reviewed changes

Simplify

47f7574

Crabcyborg added the run tests label Apr 27, 2026

Fix more eslint issues

f94f0ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve support for conditional Square payments#2594

Improve support for conditional Square payments#2594
Crabcyborg wants to merge 7 commits intomasterfrom
improve_support_for_conditional_square

Crabcyborg commented Nov 19, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

Review skipped

Uh oh!

deepsource-io Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

deepsource-io Bot Apr 27, 2026

Uh oh!

deepsource-io Bot Apr 27, 2026

Uh oh!

deepsource-io Bot Apr 27, 2026

Uh oh!

deepsource-io Bot Apr 27, 2026

Uh oh!

deepsource-io Bot Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Crabcyborg commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

Uh oh!

deepsource-io Bot Apr 27, 2026

Choose a reason for hiding this comment

Unexpected string concatenation

Uh oh!

deepsource-io Bot Apr 27, 2026

Choose a reason for hiding this comment

Unexpected var, use let or const instead

Uh oh!

deepsource-io Bot Apr 27, 2026

Choose a reason for hiding this comment

Unexpected string concatenation

Uh oh!

deepsource-io Bot Apr 27, 2026

Choose a reason for hiding this comment

Unexpected string concatenation

Uh oh!

deepsource-io Bot Apr 27, 2026

Choose a reason for hiding this comment

Prefer using an optional chain expression instead, as it's more concise and easier to read

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Crabcyborg commented Nov 19, 2025 •

edited

Loading

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

deepsource-io Bot commented Apr 27, 2026 •

edited

Loading